Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated account_notifications to account_user_grants to request helpers #528

Conversation

ErikZilber
Copy link
Contributor

📝 Description

Migrated the following files from directly referencing the Resty client in favor of using the new request helpers:
account_notifications.go
account_oauth_client.go
account_payments.go
account_settings.go
account_transfer.go
account_user_grants.go

@ErikZilber ErikZilber requested a review from a team as a code owner June 17, 2024 18:57
@ErikZilber ErikZilber requested review from jriddle-linode and ykim-1 and removed request for a team June 17, 2024 18:57
Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified tests and fixtures locally

Copy link
Contributor

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working locally, good to get this converted.

@ErikZilber ErikZilber force-pushed the TPT2871_migrate_account_notifications_to_account_user_grants branch from 149fe2d to b137ca5 Compare June 20, 2024 16:03
@lgarber-akamai lgarber-akamai merged commit 7f8f5ce into linode:main Jun 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants