Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated account to account_logins to request helpers #527

Conversation

ErikZilber
Copy link
Contributor

📝 Description

Migrated the following files from directly referencing the Resty client in favor of using the new request helpers:
account.go
account_availability.go
account_betas.go
account_events.go
account_invoices.go
account_logins.go

@ErikZilber ErikZilber requested a review from a team as a code owner June 14, 2024 19:37
@ErikZilber ErikZilber requested review from zliang-akamai and ykim-1 and removed request for a team June 14, 2024 19:37
@lgarber-akamai lgarber-akamai requested review from lgarber-akamai and removed request for lgarber-akamai June 17, 2024 13:57
@ErikZilber ErikZilber marked this pull request as draft June 17, 2024 14:56
account_betas.go Outdated Show resolved Hide resolved
@ErikZilber ErikZilber marked this pull request as ready for review June 17, 2024 17:11
@lgarber-akamai lgarber-akamai self-requested a review June 17, 2024 19:19
@ErikZilber ErikZilber force-pushed the TPT2870_migrate_account_to_account_logins branch from ac0c5c8 to 407dd8c Compare June 20, 2024 17:23
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look much simpler and cleaner now, nice job!

@jriddle-linode jriddle-linode merged commit 0b5959c into linode:main Jun 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants