Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Updated and EOL Fields to Image #477

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Mar 15, 2024

📝 Description

This is to add missing fields to the Image struct.

✔️ How to Test

make ARGS="-run TestImage_GetFound" fixtures
import (
	"context"
	"fmt"
	"os"
	"time"

	"github.com/linode/linodego"
)

func main() {
	client := linodego.NewClient(nil)
	client.SetToken(os.Getenv("LINODE_TOKEN"))
	image, err := client.GetImage(context.Background(), "linode/ubuntu22.04")
	if err != nil {
		panic(err)
	}
	
	fmt.Println(image.EOL.Format(time.RFC3339))
	fmt.Println(image.Updated.Format(time.RFC3339))
}

@zliang-akamai zliang-akamai requested a review from a team as a code owner March 15, 2024 18:47
@zliang-akamai zliang-akamai requested review from jriddle-linode and yec-akamai and removed request for a team March 15, 2024 18:47
@zliang-akamai zliang-akamai changed the title Zhiwei/image fields Add Updated and EOL Fields to Image Mar 15, 2024
@zliang-akamai zliang-akamai added the improvement for improvements in existing functionality in the changelog. label Mar 15, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@zliang-akamai zliang-akamai merged commit 73f38b5 into linode:main Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants