fix: [BREAKING] Support ID field for nodes in NodeBalancerConfigRebuildOptions

[lgarber-akamai]

📝 Description

This change resolves an issue that prevented existing nodes from being preserved using the id field in the NodeBalancer Config Rebuild response body. This works by creating a new NodeBalancerConfigRebuildNodeOptions struct that extends the NodeBalancerNodeCreateOptions struct with a new ID field.

NOTE: This IS a breaking change but we deemed it low-impact enough to be worth making.

✔️ How to Test

The following test steps assume you have pulled down this PR locally.

Integration Testing

make ARGS="-run TestNodeBalancer_Rebuild" fixtures

Manual Testing

1. In a linodego sandbox environment (e.g. dx-devenv), run the following:

package main

import (
	"context"
	"fmt"
	"github.com/linode/linodego"
	"github.com/sanity-io/litter"
	"log"
	"os"
)

func main() {
	ctx := context.Background()

	client := linodego.NewClient(nil)
	client.SetToken(os.Getenv("LINODE_TOKEN"))

	inst, err := client.CreateInstance(
		ctx,
		linodego.InstanceCreateOptions{
			Label:     "test-instance",
			Region:    "us-mia",
			Type:      "g6-nanode-1",
			PrivateIP: true,
		},
	)
	if err != nil {
		log.Fatal(err)
	}

	nbLabel := "test-nb"

	nb, err := client.CreateNodeBalancer(
		ctx,
		linodego.NodeBalancerCreateOptions{
			Label:  &nbLabel,
			Region: "us-mia",
			Configs: []*linodego.NodeBalancerConfigCreateOptions{
				{
					Port: 80,
					Nodes: []linodego.NodeBalancerNodeCreateOptions{
						{
							Address: inst.IPv4[1].String() + ":80",
							Label:   "test-node",
						},
					},
				},
			},
		},
	)
	if err != nil {
		log.Fatal(err)
	}

	configs, err := client.ListNodeBalancerConfigs(ctx, nb.ID, nil)
	if err != nil {
		log.Fatal(err)
	}
	config := configs[0]

	oldNodes, err := client.ListNodeBalancerNodes(ctx, nb.ID, config.ID, nil)
	if err != nil {
		log.Fatal(err)
	}

	oldNode := oldNodes[0]
	fmt.Println("Old node:")
	litter.Dump(oldNode)
	fmt.Println()

	_, err = client.RebuildNodeBalancerConfig(
		ctx,
		nb.ID,
		config.ID,
		linodego.NodeBalancerConfigRebuildOptions{
			Port: 81,
			Nodes: []linodego.NodeBalancerConfigRebuildNodeOptions{
				{
					NodeBalancerNodeCreateOptions: oldNode.GetCreateOptions(),
					ID:                            oldNode.ID,
				},
			},
		},
	)
	if err != nil {
		log.Fatal(err)
	}

	newNodes, err := client.ListNodeBalancerNodes(ctx, nb.ID, config.ID, nil)
	if err != nil {
		log.Fatal(err)
	}

	fmt.Println("Updated node:")
	litter.Dump(newNodes[0])
}

2. Ensure the output is similar to the following:

Old node:
linodego.NodeBalancerNode{
  ID: 1943768499,
  Address: "192.168.149.92:80",
  Label: "test-node",
  Status: "Unknown",
  Weight: 50,
  Mode: "accept",
  ConfigID: 869351,
  NodeBalancerID: 552780,
}

Updated node:
linodego.NodeBalancerNode{
  ID: 1943768499,
  Address: "192.168.149.92:80",
  Label: "test-node-updated",
  Status: "Unknown",
  Weight: 50,
  Mode: "accept",
  ConfigID: 869351,
  NodeBalancerID: 552780,
}

3. Ensure the IDs of both nodes match and the label of the updated node is test-node-updated.

[yec-akamai]

Nice work! Tests all passed locally 🎉

[zliang-akamai]

Works on my end, nice work!