Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Implement ListVPCIPAddresses #468

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Mar 7, 2024

📝 Description

Need to merge this PR first then rebase this PR.

This for adding ListVPCIPAddresses function to the client.

✔️ How to Test

GHA Run: https://github.com/linode/linodego/actions/runs/8195608429

make ARGS="-run TestVPC_ListIPAddresses" fixtures
import (
	"context"
	"encoding/json"
	"fmt"
	"os"

	"github.com/linode/linodego"
)

func main() {
	client := linodego.NewClient(nil)
	client.SetToken(os.Getenv("LINODE_TOKEN"))

	addresses, err := client.ListVPCIPAddresses(context.Background(), linodego.NewListOptions(1, "{\"linode_id\": 55774762}"))
	if err != nil {
		panic(err)
	}
	
	jsonAddresses, _ := json.Marshal(addresses)
	fmt.Println(string(jsonAddresses))
}

@zliang-akamai zliang-akamai requested a review from a team as a code owner March 7, 2024 22:21
@zliang-akamai zliang-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team March 7, 2024 22:21
@zliang-akamai zliang-akamai changed the title Zhiwei/list vpc ips Implement ListVPCIPAddresses Mar 7, 2024
@zliang-akamai zliang-akamai changed the title Implement ListVPCIPAddresses new: Implement ListVPCIPAddresses Mar 7, 2024
instance_ips.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

Copy link
Contributor

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zliang-akamai zliang-akamai merged commit 5953a7c into linode:main Mar 13, 2024
4 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/list-vpc-ips branch March 13, 2024 04:24
@zliang-akamai zliang-akamai added the new-feature for new features in the changelog. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants