Make multiple fields nullable (nilable) in networking interface #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
ykim-1 and
yec-akamai
and removed request for
a team
yec-akamai
reviewed
Jan 19, 2024
There was a problem hiding this comment.
I ran the intergration tests locally but keep getting a failed case:
instance_config_test.go:311: failed to update linode interfaces: configs do not match
instance_config_test.go:328: failed to update linode interfaces: configs do not match
--- FAIL: TestInstance_ConfigInterfaces_Update (0.00s)
Do you mind double checking the case?
|
Hi @yec-akamai, thanks for the review! Did you test it with production API? We will have to wait until next week to get these passed when the API change deployed to production. You can try testing it with alpha and these errors should be gone. |
zliang-akamai
force-pushed
the
zhiwei/vpc-interface-schema-nullable
branch
from
76dc5bf
to
e283e29
Compare
yec-akamai
approved these changes
Jan 23, 2024
ykim-1
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The API schema change made some fields nullable now.
linodegochange in this PR will work with both the alpha and the production, but some tests will be failed before the API schema change deployed to the production. We may want to hold on for now, but feel free to review though. Fixtures will be added after the production deployment.✔️ How to Test
make ARGS="-run TestInstance_Config" fixtures