Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: Support account_availability #434

Merged
merged 4 commits into from
Dec 5, 2023
Merged

new: Support account_availability #434

merged 4 commits into from
Dec 5, 2023

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented Dec 1, 2023 •
edited
Loading

📝 Description

Implement account_availability to support listing and getting available region and the resources which are UNAVAILABLE to a customer.

✔️ How to Test

Run test cases:
make testunit
make testint

@yec-akamai yec-akamai requested a review from a team as a code owner December 1, 2023 21:49
@yec-akamai yec-akamai requested review from jriddle-linode and ykim-1 and removed request for a team December 1, 2023 21:49
lgarber-akamai
lgarber-akamai approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good and all tests pass as expected other than the dc -> region change:

make testunit

export LINODE_URL=...
make ARGS="-run TestAccountAvailability" fixtures

jriddle-linode
jriddle-linode approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Passes locally.

@yec-akamai
Copy link
Contributor Author

All changes look good and all tests pass as expected other than the dc -> region change:

make testunit

export LINODE_URL=...
make ARGS="-run TestAccountAvailability" fixtures

Thanks for catching it! I only realized we changed from id to dc when I was implementing this. Just pushed the change to region.

@yec-akamai yec-akamai merged commit 392c33a into proj/dc-get-well Dec 5, 2023
5 checks passed
@yec-akamai yec-akamai deleted the TPT-2451/support-account-availability branch December 5, 2023 16:16
yec-akamai added a commit that referenced this pull request Dec 14, 2023
@yec-akamai
new: Support account_availability (#434) (#444)
5119842 
* support account_availability

* fix lint

* fix client test

* update dc to region
@shanduur shanduur mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jriddle-linode jriddle-linode jriddle-linode approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@ykim-1 ykim-1 Awaiting requested review from ykim-1 ykim-1 is a code owner automatically assigned from linode/dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yec-akamai @jriddle-linode @lgarber-akamai