test: Randomize root pass for Linode creations in integration tests #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-1
requested review from
lgarber-akamai and
amisiorek-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
All tests are passing locally, LGTM!
@ykim-1 Could you re-run and push up relevant filters before merging?
amisiorek-akamai
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
In integration tests, we currently use public hard coded root passwords for Linode instances. To enhance security, transitioning to randomly generated root passwords during tests instead.
✔️ How to Test
Here are list of tests that were changed:
make ARGS='-run TestInstance_Disk_ListMultiple' fixtures
make ARGS='-run TestInstance_Disk_ResetPassword' fixtures
make ARGS='-run TestInstance_Rebuild' fixtures
make ARGS='-run TestEventPoller_InstancePower' fixtures
make ARGS='-run TestWaitForResourceFree' fixtures
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.