fix: edit test.yml to allow gha to mark build as x when tests fail
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-1
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
ykim-1
changed the title
x when tests failx when tests fail
zliang-akamai
approved these changes
Nov 3, 2023
zliang-akamai
requested review from
a team,
jriddle-linode and
vshanthe
and removed request for
a team
|
This looks good to me. The lint error in the CI is not related to the change. |
vshanthe
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
For most DX repositories, the failing tests are no longer reported on GitHub.
If tests failed, the red cross mark (×) is shown instead of the green check mark.
✔️ How to Test
Need final verification with the corresponding integration test workflow after merging to main/dev branch
How do I run the relevant unit/integration tests?
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.