Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and refactor TestAccountBetaPrograms #411

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Oct 19, 2023

📝 Description

This PR is to fix an issue that causes the integration test of account beta to be failed. (failed example)

I also refactor the test case a little bit to make the workflow to produce a more reliable result.

✔️ How to Test

make ARGS='-run TestAccountBeta' fixtures

GHA test run: https://github.com/linode/linodego/actions/runs/6576638760

@zliang-akamai zliang-akamai requested a review from a team as a code owner October 19, 2023 04:03
@zliang-akamai zliang-akamai requested review from jriddle-linode and ykim-1 and removed request for a team October 19, 2023 04:03
@ykim-1
Copy link
Contributor

ykim-1 commented Oct 20, 2023

Test passed locally. Great job!

Copy link
Contributor

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good standard to set.

@zliang-akamai zliang-akamai merged commit f36e2e3 into main Oct 20, 2023
5 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/fix-account-beta-test branch November 15, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants