updating errors coverage to 100% #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
There was a type error in my last test with
*errorvs.errorwhich I missed so I fixed that and added tests for the rest of the file. Note to reviewer...coupleAPIErrorsto return earlier instead of putting all the coupling logic inside an if block, spiritually the same but easier to follow.client.SetDebug(true)in generic html error because it wasn't really benefiting anything and making the test output spammy. if you want it back, I'll happily uncomment itWhat does this PR do and why is this change necessary?
Rewrites the errors tests to give 100% coverage, because... tests.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
make testunit📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.