Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload test results only on main push #396

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

ykim-1
Copy link
Contributor

@ykim-1 ykim-1 commented Oct 5, 2023

📝 Description

Quick fix to upload test results only on main push and not on PRs

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-1 ykim-1 requested a review from a team as a code owner October 5, 2023 16:48
@lgarber-akamai lgarber-akamai requested a review from a team October 5, 2023 16:50
@lgarber-akamai lgarber-akamai requested a review from a team October 5, 2023 16:53
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
I think in the future we can make another job and pass the JSON value to there from this job and add the if statement there to filter out non-main-push run. I think it can be prettier that way.

@ykim-1 ykim-1 merged commit cb9a279 into linode:main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants