add GetFirewall method #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xch4z
force-pushed
the
feat/get-firewall
branch
2 times, most recently
from
84ab503
to
bfee9f3
Compare
0xch4z
force-pushed
the
feat/get-firewall
branch
from
bfee9f3
to
3c80824
Compare
0xch4z
commented
Apr 12, 2020
| @@ -18,7 +18,7 @@ type NetworkAddresses struct { | |||
|
|
|||
| // A FirewallRule is a whitelist of ports, protocols, and addresses for which traffic should be allowed. | |||
| type FirewallRule struct { | |||
| Ports string `json:"ports"` | |||
| Ports string `json:"ports,omitempty"` | |||
There was a problem hiding this comment.
This is important, as with ICMP, ports is invalid if present in the request.
| @@ -19,7 +20,7 @@ var ( | |||
| func TestListFirewalls(t *testing.T) { | |||
| client, _, teardown, err := setupFirewall(t, []firewallModifier{ | |||
| func(createOpts *linodego.FirewallCreateOptions) { | |||
| createOpts.Label = randString(12, lowerBytes, digits) + "-linodego-testing" | |||
| createOpts.Label = randString(12, lowerBytes, upperBytes) + "-linodego-testing" | |||
There was a problem hiding this comment.
A Firewall's label cannot begin with a number, rerunning this threw an error because of it.
phillc
approved these changes
Apr 13, 2020
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
add GetFirewall method
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 13, 2023
add GetFirewall method
lgarber-akamai
pushed a commit
to lgarber-akamai/linodego
that referenced
this pull request
Feb 14, 2023
add GetFirewall method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.