-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add Calico Inbound and Outbound policies to LKE nodes for E2E #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far! Just a few tiny suggestions and this should be good to go 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on my end, nice work!
Tested using the following:
- Create two LKE clusters:
linode-cli lke cluster-create --region us-mia --k8s_version 1.29 --node_pools.type g6-standard-1 --node_pools.count 2 --label test-cluster-1
linode-cli lke cluster-create --region us-mia --k8s_version 1.29 --node_pools.type g6-standard-1 --node_pools.count 2 --label test-cluster-2
- Apply calico rules using provided script:
cd scripts
./lke_calico_rules_e2e.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📝 Description
A new script,
lke_calico_rules_e2e.sh
, has been added and is called in the E2E workflow file after theRun the integration test suite step
ine2e-suite.yml
Key Points:
kubectl
andcalicoctl
binaries are required as pre-req which are downloed in the e2e worflow file✔️ How to Test
PR has been checked out
remove_lke_clusters()
line 64 intest_clusters.py
make MODULE="lke" testint
cd scripts && ./lke_calico_rules_e2e.sh
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.