Test and fix for #70, linkmk2sheets for prefixes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test uses SchemaBuilder to generate a fake schema with only prefixes in it We then use the generic roundtripping mechanism in the test framework to see if we can go Schema->TSV->Schema, retaining the prefixes This uses a simple TSV specification with two columns: - prefix - prefix_reference As expected, this test failed, so we included a fix here. The bug was simply that Prefix was not considered among the list of possible Elements (it's not really an element in the same way Class, Slot, etc are). To fix this we add a condition checking to see if there is a column 'prefix', and if so, if a prefix object is passed, then use the prefix column as the primary ID (i.e prefix_prefix)
turbomam
approved these changes
Sep 15, 2022
Closed
cmungall
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test uses SchemaBuilder to generate a fake schema with
only prefixes in it
We then use the generic roundtripping mechanism in the
test framework to see if we can go Schema->TSV->Schema,
retaining the prefixes
This uses a simple TSV specification with two columns:
As expected, this test failed, so we included a fix here.
The bug was simply that Prefix was not considered among
the list of possible Elements (it's not really an element
in the same way Class, Slot, etc are).
To fix this we add a condition checking to see if there is
a column 'prefix', and if so, if a prefix object is passed,
then use the prefix column as the primary ID (i.e prefix_prefix)
Fixes #70