Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 25 range override #27

Merged
merged 4 commits into from
May 20, 2022
Merged

Issue 25 range override #27

merged 4 commits into from
May 20, 2022

Conversation

turbomam
Copy link
Contributor

@turbomam turbomam commented Mar 4, 2022

issue #25

My contributions from #24 also got committed here

The range override and OWL consequences are triggered by make examples/output/range_override_examples_reasoned.ttl

@turbomam turbomam requested a review from cmungall March 4, 2022 19:20
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to merge for now but this is a bit odd

  • what is placeholder.txt?
  • why is a txt file in bin?
  • ideally these would be tests not examples

@cmungall
Copy link
Member

ah I see the step to get robot. I usually do a README.md as a placeholder that explains why the file is there

but not totally sure we want to introduce robot into the makefile in the first place

ok to merge though, can iterate

@sierra-moxon sierra-moxon merged commit 29702b5 into main May 20, 2022
@turbomam turbomam deleted the issue-25-range-override branch February 14, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants