Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples should roundtrip #52

Closed
cmungall opened this issue Jul 12, 2022 · 0 comments · Fixed by #53
Closed

Examples should roundtrip #52

cmungall opened this issue Jul 12, 2022 · 0 comments · Fixed by #53

Comments

@cmungall
Copy link
Member

When converting from sheets to linkml, a column that maps to examples will be hard-wired to generate Example(value=v) for each v in the value cell.

When this is reversed back from linkml to sheets, this causes an error

The behavior should be symmetric

More broadly, there should be a well-documented solution for mapping complex values to flat spreadsheet cells, rather than relying on hardwiring
cmungall added a commit that referenced this issue Jul 12, 2022
@cmungall
Adding documentation.
6664ea0 
Fixes Mark's issue with duplicate slots for slot-only specs.
Added hardcoded behavior for examples, fixes #52
@cmungall cmungall mentioned this issue Jul 12, 2022
Merged
cmungall added a commit that referenced this issue Jul 12, 2022
@cmungall
docs and tests (#53)
f9daa99 
* Additional tests for slots in the context of classes

* Adding documentation.
Fixes Mark's issue with duplicate slots for slot-only specs.
Added hardcoded behavior for examples, fixes #52

* Fixes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs and tests linkml/schemasheets
1 participant
@cmungall