-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align declared supported python versions #64
Conversation
Poetry specifies that only Python versions from 3.9 upwards are supported. But the package metadata (mostly visible over PyPI) was still declaring support for Python 3.7 and 3.8. This patch fixes it. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
4c6168b
to
27d29c1
Compare
Black 24.1.1 requires a newline after a docstring. This patch adapts some files to fulfill that requirement. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
I am happy to see increased minimum versions! I don't know what the effect is on other linkml infrastructure, though |
@cthoyt we are already declaring support for Python 3.9 upwards in the I can nevertheless understand that you prefer not to merge if you don't have the overview about the impact on other components. I'll assign it @pkalita-lbl, since he appears to have a good overview of the different components. |
I'm all for it! However, I am not responsible for this package, so better to have @sierra-moxon take a look at it. |
Yeah I'll absolutely leave it up to @sierra-moxon to make the final calls about this package. I'll just note that I reviewed linkml/linkml-runtime#286 before I saw this. I guess this package's I'm also just curious about this:
The only thing I see in the docs is this statement about installing Python itself:
And that's just to install/run Poetry itself. That shouldn't have any bearing on the dependencies of packages developed using Poetry. |
I've already explained the reason why I claim, that Prefixmaps doesn't support Python <3.9 as of now! My wording might have been a bit ambiguous. What I meant is that the |
I've built the package from the source code corresponding tag 0.2.0 with So my PR is not removing support for Python 3.8. It was already removed the moment this commit was merged into the |
I have to admit though, that I'm puzzled by the fact that the tests on Python 3.8 seem to run successfuly! I don't know if dependency specification applies differently to |
PR #66 already fixes support for Python 3.8 and aligns declared supported python versions (kudos to @pkalita-lbl ). Therefore this PR is not needed anymore, closing it. |
Poetry specifies that only Python versions from 3.9 upwards are supported. But the package metadata (mostly visible over PyPI) was still declaring support for Python 3.7 and 3.8.
This patch fixes it.