Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingest for Bioportal prefixes #28

Merged
merged 22 commits into from
Nov 1, 2022
Merged

Add ingest for Bioportal prefixes #28

merged 22 commits into from
Nov 1, 2022

Conversation

caufieldjh
Copy link
Contributor

@caufieldjh caufieldjh commented Oct 26, 2022

  • Ingest (including non-canonical prefixes)
  • Curated yaml (including non-canonical prefixes)
  • Tests

@caufieldjh caufieldjh marked this pull request as ready for review October 26, 2022 22:11
@@ -24,7 +24,16 @@
location: http://prefix.cc/context.jsonld
comments:
- prefix.cc is quite a messy source, it has many outdated expansions for OBO ontologies, lots of strange duplicates etc
- we recommend this is not used in isolatiom but is instead combined, lower in the priority order
- we recommend this is not used in isolation but is instead combined, lower in the priority order
semantic: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what makes a context semantic or not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been taking this to mean that the named resources already contains semantic maps without requiring further processing, but perhaps that isn't @cmungall 's intent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, these are all semantic prefix maps, aren't they?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it generates a namespace used as a resource in an RDF triple

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense, but how does this annotation apply at a context level?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, everything in this repo should be geared towards semantic namespaces.. also this doesn't conform to https://github.com/linkml/prefixmaps/blob/main/src/prefixmaps/datamodel/context.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm puzzled as to how the semantic slot got there to begin with if it isn't in the data model. Going to remove it.

@@ -0,0 +1,509 @@
name: bioportal
prefixes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be cool if we could converge on the "extended prefix map" schema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice, yes - but for now, this is still parsed to canonical/prefix_alias/namespace_alias so I'll save adopting the extended schema for a near-future PR

@cmungall cmungall merged commit bb1618a into main Nov 1, 2022
@caufieldjh caufieldjh deleted the parse_bioportal branch November 1, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants