Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple healthz handler #94

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Add simple healthz handler #94

merged 2 commits into from
Jul 30, 2018

Conversation

bakins
Copy link
Contributor

@bakins bakins commented Jul 25, 2018

For #93

This creates a very simple HTTP endpoint to be used for liveness and readiness checks. In this initial version, it only returns OK. In the future, we may want to check additional functionality before returning OK.

We can reuse this listener for things such as prometheus metrics, as mentioned in #23, in the future, if desired.

@linki
Copy link
Owner

linki commented Jul 28, 2018

That looks good.

I was wondering – since you already mentioned /metrics – what's your opinion about changing the flag name to --metrics-address similar to ExternalDNS? Just --address seems a bit generic and "is it healthy: yes or no" can also be considered a metric, imo.

Let me know what you think.

@bakins
Copy link
Contributor Author

bakins commented Jul 28, 2018

@linki --metrics-address sounds good to me. I'll make that change. Also, in another PR, I can add basic Prometheus metrics if that would be useful.

@linki
Copy link
Owner

linki commented Jul 29, 2018

@bakins yes, please do that.

@linki linki merged commit 1a0a89a into linki:master Jul 30, 2018
@linki
Copy link
Owner

linki commented Jul 30, 2018

Thanks @bakins 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants