Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only remove document content #638

Merged
merged 2 commits into from
Mar 23, 2024
Merged

only remove document content #638

merged 2 commits into from
Mar 23, 2024

Conversation

bourgeoa
Copy link
Contributor

see issue#637
updater.update() fails on chat with thread since changes in removeDocument() that also removes metadata

@bourgeoa bourgeoa linked an issue Feb 18, 2024 that may be closed by this pull request
updater.update() fails on insert with error but still can't figure out what editing protocol it supports #637
Closed
@bourgeoa bourgeoa self-assigned this Feb 18, 2024
@bourgeoa bourgeoa added the bug label Feb 18, 2024
@bourgeoa bourgeoa mentioned this pull request Feb 18, 2024
Open
29 tasks
jeff-zucker
jeff-zucker approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jeff-zucker jeff-zucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@bourgeoa bourgeoa merged commit 2d89176 into main Mar 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-zucker jeff-zucker jeff-zucker approved these changes

@angelo-v angelo-v Awaiting requested review from angelo-v

@timbl timbl Awaiting requested review from timbl

Assignees

@bourgeoa bourgeoa

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updater.update() fails on insert with error but still can't figure out what editing protocol it supports
2 participants
@bourgeoa @jeff-zucker