Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use relative paths, clean up asserted output #26

Merged
merged 5 commits into from
Sep 20, 2024
Merged

feat: Use relative paths, clean up asserted output #26

merged 5 commits into from
Sep 20, 2024

Conversation

Dimava
Copy link
Contributor

@Dimava Dimava commented Sep 19, 2024

This makes output reproduceable so you can just assertEquals the whole output

@kazushisan kazushisan changed the title Use relative paths, clean up asserted output feat: Use relative paths, clean up asserted output Sep 20, 2024
@kazushisan kazushisan added the feature New feature or request label Sep 20, 2024
kazushisan
kazushisan approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@kazushisan kazushisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dimava thank you! I've made some minor changes but LGTM!

@kazushisan kazushisan merged commit 2d5b734 into line:main Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazushisan kazushisan kazushisan approved these changes

Assignees

@Dimava Dimava

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dimava @kazushisan