Skip to content

Commit

Permalink
net: dsa: Bring back device detaching in dsa_slave_suspend()
Browse files Browse the repository at this point in the history
Commit 448b448 ("net: dsa: Add lockdep class to tx queues to avoid
lockdep splat") removed the netif_device_detach() call done in
dsa_slave_suspend() which is necessary, and paired with a corresponding
netif_device_attach(), bring it back.

Fixes: 448b448 ("net: dsa: Add lockdep class to tx queues to avoid lockdep splat")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
ffainelli authored and davem330 committed Jan 25, 2017
1 parent d5bdc02 commit f154be2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/dsa/slave.c
Original file line number Diff line number Diff line change
Expand Up @@ -1201,6 +1201,8 @@ int dsa_slave_suspend(struct net_device *slave_dev)
{
struct dsa_slave_priv *p = netdev_priv(slave_dev);

netif_device_detach(slave_dev);

if (p->phy) {
phy_stop(p->phy);
p->old_pause = -1;
Expand Down

0 comments on commit f154be2

Please sign in to comment.