webauthn + refactor

[tt0mmy]

• adds webauthn identity so that users can create an account with their hsm
• change from Identity to Address
• adds AsyncAttribute handling
• adds idstore
• maxWorkers: 1 per jest-worker fails with "Do not know how to serialize a BigInt" in messageParent.ts instead of showing the actual assertion error message when there are 2 or more test suite files executing in parallel jestjs/jest#11617

[hansl]

?

[tt0mmy]

this.getCommon was removed from CoseKey, moved into getCoseKey for each Identity.
code snip below is from current main branch and for ANONYMOUS, we still create the common structure

// this.getProtectedHeader (ANONYMOUS) -> new CoseKey(ANONYMOUS) -> getCommon(ANONYMOUS)

    const protectedHeader = this.getProtectedHeader(
      keys ? keys.publicKey : ANONYMOUS
    );
    
    private static getProtectedHeader(publicKey: Key): CborMap {
      const coseKey = new CoseKey(publicKey);
      const protectedHeader = new Map();
      protectedHeader.set(1, -8); // alg: "Ed25519"
      protectedHeader.set(4, coseKey.keyId); // kid: kid
      protectedHeader.set("keyset", coseKey.toCborData());
      return protectedHeader;
    }


export class CoseKey {
  key: CborMap;
  keyId: CborData;
  private common: CborMap;

  constructor(publicKey: Key) {
   // publicKey would be ANONYMOUS here
    this.common = this.getCommon(publicKey);
    this.keyId = this.getKeyId();
    this.key = this.getKey();
  }

  private getCommon(publicKey: Key) {
    const common = new Map();
    common.set(1, 1); // kty: OKP
    common.set(3, -8); // alg: EdDSA
    common.set(-1, 6); // crv: Ed25519
    common.set(4, [2]); // key_ops: [verify]
    common.set(-2, publicKey); // x: publicKey
    return common;
  }

[tt0mmy]

Weird thing about the anonymous identity having a public key...

public key has been removed from anon identity.

[tt0mmy]

@hansl , now ready for review

[hansl]

Suggested change

	toJson() {
	toJSON() {

[hansl]

Suggested change

	abstract toJson(): unknown
	abstract toJSON(): unknown

[hansl]

This could be protected or private

[hansl]

Suggested change

	async sign(): Promise<ArrayBuffer> {
	async sign(): Promise<ArrayBuffer> {
	// This value ends up in the signature COSE field, but we don't
	// use it for WebAuthn verification, so we simply set it to
	// EMPTY.

[hansl]

Add comment here please.

[hansl]

Please add a comment explaining why we only use ES256.

[hansl]

Can you add a TODO and an issue on this repo for your thoughts on how this can be made better?

[hansl]

Move this into a const.ts file or something similar.

[hansl]

Suggested change

	async function fetchAsyncStatus(
	n: Network,
	asyncToken: ArrayBuffer,
	): Promise<Message> {
	const start = new Date().getTime()
	let waitTime = ONE_SECOND
	let isDurationReached = false
	let res = new Message(new Map())
	while (!isDurationReached) {
	res = (await n.call("async.status", new Map([[0, asyncToken]]))) as Message
	const payload = res.getPayload()
	if (payload) {
	if (payload.has(0)) {
	const asyncResult = payload.get(0)
	if (asyncResult === 3 && payload.has(1)) {
	const msg = cbor.decode(payload.get(1)).value
	return new Message(msg)
	}
	}
	}
	const now = new Date().getTime()
	isDurationReached = now - start >= ONE_MINUTE
	await sleep(waitTime)
	waitTime *= 1.5
	}
	enum AsyncStatusResult {
	Unknown = 0,
	Queued = 1,
	Processing = 2,
	Done = 3,
	Expired = 4,
	}
	type AsyncStatusPayload = { result: AsyncStatusResult.Unknown }
	| { result: AsyncStatusResult.Queued }
	| { result: AsyncStatusResult.Processing }
	| { result: AsyncStatusResult.Expired }
	| {
	result: AsyncStatusResult.Done,
	payload: ArrayBuffer,
	}
	function parseAsyncStatusPayload(cbor: Map<number, unknown>): AsyncStatusPayload {
	const index = cbor.get(0);
	if (typeof index != "number") {
	throw new Error("Invalid async result")
	}
	if (!(index in AsyncStatusResult)) {
	throw Error("Invalid async result")
	}
	const result = index as AsyncStatusResult
	let payload = undefined;
	if (result === AsyncStatusResult.Done) {
	payload = cbor.get(1) as ArrayBuffer;
	if (!payload || !Buffer.isBuffer(payload)) {
	throw Error("Invalid async result")
	}
	}
	return { result, payload } as AsyncStatusPayload
	}
	async function pollAsyncStatus(
	n: Network,
	asyncToken: ArrayBuffer,
	options: {
	timeoutInMsec: number,
	waitTimeInMsec: number,
	} = {}
	): Promise<Message> {
	const timeoutInMsec = options.timeoutInMsec ?? ONE_MINUTE;
	const waitTimeInMsec = options.waitTimeInMsec ?? ONE_SECOND;
	const end = new Date() + timeoutInMsec
	while (true) {
	const res = (await n.call("async.status", new Map([[0, asyncToken]]))) as Message
	const result = parseAsyncStatusPayload(res.getPayload())
	switch (result.result) {
	case AsyncStatusResult.Done:
	return new Message(cbor.decode(result.payload).value)
	case AsyncStatusResult.Expired:
	throw new Error("Async Expired before getting a result")
	}
	if (Date.now() >= end) {
	return res;
	}
	await sleep(waitTime)
	waitTime *= 1.5
	}

[hansl]

BTW you should request a follow up review using the little icon on the right: