Write final PGNs to files before quitting #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, pressing Ctrl-C to quit lichess-bot would skip writing the PGN records of any active games, even if the config said to wait for active games to finish. PGN records are now sent by a separate queue than the control stream events to make sure they are saved before quitting.
MarkZH
changed the title
AttackingOrDefending
approved these changes
Jul 22, 2024
AttackingOrDefending
merged commit f776356
into
lichess-bot-devs:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
Prior to this change, pressing Ctrl-C to quit lichess-bot would skip writing the PGN records of any active games, even if the config said to wait for active games to finish. PGN records are now sent by a separate queue than the control stream events to make sure they are saved before quitting.
Related Issues:
N/A
Checklist:
Screenshots/logs (if applicable):
N/A