-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard Lua support #60
Conversation
Hi @rolandlo, This looks great! Nice job. Should this PR wait for the ffi PRs to merge? Stepping back slightly, I'm no longer using Lua much myself, so I no longer have a personal use for lua-vips. Would you be interested in taking over this repo? You'd have complete freedom to do anything you liked with it. |
Thanks for the offer. I am tempted to accept, since I will have personal use for |
I think this project needs an experienced Lua person -- I like Lua, but I've only done a couple of little pico8 games, I'm sure you're much stronger than me on on things like package conventions. Thanks for considering it anyway. |
My experience with Lua comes mostly from writing Lua plugins for Xournal++ (note taking software) and extending and supervising the Lua API in the C++ code of Xournal++. I don't know if that counts as "experienced" in any way. Lua is a great language and libvips is a pretty impressive library, so it would be really interesting to work on One question: What are some of the main tasks in your view that Another question: What versions of libvips should |
The things that come to mind are:
And of course any other ideas that take your fancy. |
It has been merged today (into the maintained fork of |
Ok, that sounds reasonable to me. Thanks for the ideas. I am willing to take over maintenance. Maybe you could upload the current version (or after merging #61) to luarocks, so that there is always a fallback option for those who are sceptical with the changes made after that. |
Hey, that's great! It's always best if the package maintainer is also a user of the package, things tend to rot otherwise, a bit like gardening. You must feel free to walk away any time it stops being fun or interesting. This kind of volunteer work ought to be rewarding, or it's not worth doing. The libvips devs idle on gitter, you might like to join: https://app.gitter.im/#/room/#libvips_devchat:gitter.im |
I made you a maintiner, have fun! |
Thanks! It's an honour for me. |
This is required for standard Lua, see https://github.com/facebookarchive/luaffifb#pointer-comparison
text:replicate needs integer arguments
17b34b0
to
461f7c9
Compare
In combination with https://github.com/rolandlo/luaffifb this makes
lua-vips
work with Standard Lua. I have tested it with Lua 5.3.6 (mostly) and 5.4.6 (to a lesser degree). Compare with my announcement in #9.The whole test suite in the spec folder runs now successfully (tested on Ubuntu 23.10) and all examples in the example folder work as well.
I have also checked that the test suite still runs successfully with LuaJit (tested on Ubuntu 22.04 on a different machine).
The only commit I added to Tekenlight's maintained fork of
luaffifb
is this one which adds the__index
metamethod to thectype
metatable (in order to allow for things likevoperation.call
or<ffi-metatype>.<function name>
more generally). I hope to get it upstreamed and have raised an issue on the maintained fork.