-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRTSwitchRes Updates: Including Raspberry PI #8132
Conversation
Partil new switching method
RPi Additions new switching method
Just a general note - don't use sprintf anymore, I will clean this up for you in this case. Use snprintf instead of sprintf always. |
@alphanu1 and @twinaphex New warnings.
|
I will have a look into this. I have not noticed them while I was compiling. @orbea what is your compile environment? |
@alphanu1 Slackware Linux with gcc-8.2.0. These warnings were new with gcc8 and they used to be really spammy with RetroArch, but most have been entirely silenced/fixed until recently again. |
@alphanu1 Would this work? I'm not sure how to test this change, but it at least silences the warning here.
That would leave this warning.
Do you plan to do something with this variable or should it just be removed? |
The Screen variable will be used soon. It can remove for now though if you wish. I'm going to create a pull request in a min as there is a resolution restore issue with auto detect. |
Hey @orbea I've just read through all the comments. Looks like it's been solved. I'm not quite sure what happened with the line ending, it may have been my editor. Chers for letting me know I'll look out for it in the future. |
why was the entire RPI userland brought in? surely if you're using an RPI this is already available? |
Userland was added at: libretro#8132 However, its only use was with CRTSwitchRes together with VideoCore. Over the times, the legacy VideoCore drivers have lost usage as nowadays Mesa supports the VideoCore IV chip in RPi 0..3, and RPi 4 and/or 64-bit was never supported. Option is kept to use the legacy drivers, but it is now utilized from the OS.
New Linux switching method partially implemented. Not all system calls have been replaced yet
Linux restore desktop resolution fixed.
Monitor index switching and auto enumerate for output detection in Linux (still working on the windows method)
Added Raspberry PI Switching method. This Uses Raspiberry PI userland. Currently this is if defed, this is a temporary measure and will need to be placed in a new display server eventually. Not all of userland is currently used. However, it may in the future.