Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Selenium theme for Ozone #16960

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

ItzSelenux
Copy link
Contributor

@ItzSelenux ItzSelenux commented Sep 3, 2024

Description

A colorscheme with dark gray background, pale lettering and green accent color. For Ozone

selenium_colorscheme
ozone_selenium_settings
ozone_selenium_gamelist

@LibretroAdmin LibretroAdmin merged commit cbfe2a7 into libretro:master Sep 4, 2024
27 checks passed
@@ -429,6 +429,7 @@ enum ozone_color_theme
OZONE_COLOR_THEME_HACKING_THE_KERNEL,
OZONE_COLOR_THEME_TWILIGHT_ZONE,
OZONE_COLOR_THEME_DRACULA,
OZONE_COLOR_THEME_SELENIUM,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI adding this in the middle of the list breaks existing configs that use the themes after it..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix it before the next stable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An apology, I thought that with the review you had corrected it, in any case, the pull request has already been made and the only way to edit it seems to be by opening another pull request, do I do that?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, moving it to the end before LAST will do the job for the time being.

Would be great if in the future we would be able to get rid of all of these integer based config values and use strings instead, so the order does not matter, and thus they can finally be in alphabetic order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants