Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.8.0, 3.8.1 Windows x86_64 ASM builds crashing on startup #907

Closed
vszakats opened this issue Aug 31, 2023 · 6 comments
Closed

3.8.0, 3.8.1 Windows x86_64 ASM builds crashing on startup #907

vszakats opened this issue Aug 31, 2023 · 6 comments

Comments

@vszakats
Copy link
Contributor

vszakats commented Aug 31, 2023 •
edited
Loading

ASM-enabled LibreSSL creates bad executables. They crash before even starting, as tested with openssl.exe.

ASM-enabled 3.7.3 builds run fine. Disabling ASM with 3.8.0, 3.8.1 fixes it.

The obvious difference between 3.7.3 and 3.8.0 ASM sources is the addition of endbr64 instructions in 3.8.0. [ "Added endbr64 instructions to amd64 assembly." in ChangeLog. ]

OpenSSL added support for this in 2020, but it's not actually present in the x86_64 ASM sources generated for the MinGW target (haven't tested others), as seen in a recent 3.0.8 build.

This is the same issue as reported earlier as part of #893.
@vszakats vszakats changed the title 3.8.0, 3.8.1 Windows x64 ASM builds crashing on startup 3.8.0, 3.8.1 Windows x86_64 ASM builds crashing on startup Aug 31, 2023
@vszakats
Copy link
Contributor Author

vszakats commented Sep 5, 2023

Closing due to no interest.

@vszakats vszakats closed this as completed Sep 5, 2023
@busterb busterb reopened this Sep 5, 2023
@busterb
Copy link
Contributor

busterb commented Sep 5, 2023

We'll get to this before the stable release.

@vszakats
Copy link
Contributor Author

vszakats commented Sep 5, 2023

Thanks @busterb for working on this.

vszakats added a commit to curl/curl-for-win that referenced this issue Oct 10, 2023
@vszakats
libressl 3.8.1 (ASM disabled for x64) [ci skip]
b240364 
Pending: libressl/portable#907
@busterb
Copy link
Contributor

busterb commented Nov 2, 2023

This should be fixed now as of #922, which will be in the 3.8.2 release. Thanks @vszakats

@busterb busterb closed this as completed Nov 2, 2023
@vszakats
Copy link
Contributor Author

vszakats commented Nov 3, 2023

Thank you @busterb, I can confirm this fixed.

@vszakats
Copy link
Contributor Author

This issue returned with 3.8.3.

I'm building with CET enabled with mingw-w64. It worked fine with 3.8.2.
With 3.8.3, it's crashing the same way as 3.8.1 did.

@vszakats vszakats mentioned this issue Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vszakats @busterb