Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protocol-select/: Add Protocol Select specification #349

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

protocol-select/: Add Protocol Select specification #349

wants to merge 28 commits into from

Commits on Jul 12, 2021

  1. protocol-select/: Add first draft 

    This commit adds a first draft of the _Protocol Select_ specification.

> _Protocol Select_ is a protocol negotiation protocol. It is aimed at
negotiating libp2p protocols on connections and streams. It replaces the
_[Multistream Select]_ protocol.
    @mxinden
    mxinden committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    83c79c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. protocol-select/: Extend on uncoordinated TCP Simultaneous Open

    @mxinden
    mxinden committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    14d5f36 View commit details
    Browse the repository at this point in the history

  2. protocol-select/: Document protocol evolution

    @mxinden
    mxinden committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    cb68970 View commit details
    Browse the repository at this point in the history

  3. protocol-select/: Restructure message flow 

    - Remove `Use` and `Offer` message type, embedding the list of protocols
in the `ProtoSelect` message instead.

- Allow non-multiplexer protocols on first protocol negotiation.

- Mention nested stream protocol negotiation

- Send empty protocol list to say that one supports none of the offered
protocols.
    @mxinden
    mxinden committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    03e9e27 View commit details
    Browse the repository at this point in the history

  4. protocol-select/: Move Protocol IDs to Extension section

    @mxinden
    mxinden committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    780570b View commit details
    Browse the repository at this point in the history

  5. protocol-select: Replace mention of muxer with generic protocol

    @mxinden
    mxinden committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    c9f6814 View commit details
    Browse the repository at this point in the history

  6. protocol-select: Extend FAQ section

    @mxinden
    mxinden committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    aea6579 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. protocol-select/README.md: Fix typo 

    Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
    @mxinden @thomaseizinger
    mxinden and thomaseizinger committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a814240 View commit details
    Browse the repository at this point in the history

  2. protocol-select/README.md: Fix typo 

    Co-authored-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @mxinden @lanzafame
    mxinden and lanzafame committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    1a9adc5 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2021

  1. split the multiaddr change out of this spec

    @marten-seemann
    marten-seemann committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    9bfe115 View commit details
    Browse the repository at this point in the history

  2. reword description of the challenges associated with upgrading multis… 

    …tream
    @marten-seemann
    marten-seemann committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    4ccea37 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. add heading for Protocol Select connection establishment 

    Co-authored-by: Max Inden <mail@max-inden.de>
    @marten-seemann @mxinden
    marten-seemann and mxinden committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    7913830 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Merge pull request #354 from libp2p/protocol-select-split-addr-change 

    split the multiaddr change out of this spec
    @marten-seemann
    marten-seemann committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    fc07c19 View commit details
    Browse the repository at this point in the history

  2. protocol-select/README.md: Use bytes for Protocol ID 

    Co-authored-by: Steven Allen <steven@stebalien.com>
    @mxinden @Stebalien
    mxinden and Stebalien committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    f589bef View commit details
    Browse the repository at this point in the history

  3. protocols-select/: Describe remote accepting Protocol ID

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    843e760 View commit details
    Browse the repository at this point in the history

  4. protocol-select/: Wrap lines

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b93ff63 View commit details
    Browse the repository at this point in the history

  5. protocol-select/: Add FAQ entry on Protocol IDs

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6eb0023 View commit details
    Browse the repository at this point in the history

  6. protocol-select/: Add FAQ entry on single message type

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    24c9ea2 View commit details
    Browse the repository at this point in the history

  7. protocol-select/: Add FAQ entry on proto2 vs proto3

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    849b993 View commit details
    Browse the repository at this point in the history

  8. protocol-select/: Mention both NAT and firewalls

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    bb049b5 View commit details
    Browse the repository at this point in the history

  9. protocol-select/: Use dialer/listener instead of client/server 

    Using dialer/listener instead of client/server seems to be in line with
most other libp2p specifications.
    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    7886798 View commit details
    Browse the repository at this point in the history

  10. protocol-select: Remove links in headings

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    77470f0 View commit details
    Browse the repository at this point in the history

  11. connections/: Replace Multistream Select with Protocol Select

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b6b5d2e View commit details
    Browse the repository at this point in the history

  12. protocol-select/: Remove reference to Offer and Use message

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    324ff28 View commit details
    Browse the repository at this point in the history

  13. protocol-select/: Document Protocol Name structure

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    74ba8a3 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'libp2p/master' into protocol-select

    @mxinden
    mxinden committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    3a0c2f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. apply @yusefnapora's suggestions 

    Co-authored-by: Yusef Napora <yusef@protocol.ai>
    @marten-seemann @yusefnapora
    marten-seemann and yusefnapora committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    76d2d78 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. protocol-select/README: Mark version field as required 

    Fields in proto2 have to be either `required`, `optional` or `repeated`. Marking
`version` as `required` as it should be set at all times.
    @mxinden
    mxinden committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    6e947b8 View commit details
    Browse the repository at this point in the history