chore: remove unnecessary wrap Socket with to-iterable

[dapplion]

Socket is already an async iterable since NodeJS v10 https://nodejs.org/api/stream.html#readablesymbolasynciterator

[achingbrain]

That is handled by stream-to-it so I don't think this does any harm, though this PR has stopped the source being abortable by a passed in signal.

This is necessary because, for example, if we're dialling a peer as part of servicing an RPC request at a higher level, if that request is aborted before it's successful any resources created should be torn down, including sockets.

Is there a specific problem you'd observed that this fixes?

[dapplion]

@achingbrain sorry PRs got mixed. Updated commit to the scope of the PR.

• Not wrapping with abortable can be discussed here fix: remove abortable-iterator and close socket directly on abort #220

[achingbrain]

Did you check the linked repo? Because the socket has a [Symbol.asyncIterator] property it's returned from stream-to-it as a source without any wrapping or other funny business so I don't think this PR actually does anything. That is:

const { sink, source } = toIterable.duplex(socket)

console.info(source === socket) // true

[dapplion]

Did you check the linked repo

Yes I did, this is why this PR exists. What's the point in calling a library that does not do anything if we know that all supported versions don't need wrapping?

[achingbrain]

The code as it is is consistent and this PR doesn't fix a bug, improve performance or add a feature so I'm going to close this. Thanks for looking into it though.