Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix: replace node buffers with uint8arrays #70

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 10, 2020

All uses of node Buffers have been replaced with Uint8Arrays

BREAKING CHANGES:

  • The .data and .seq properties of messages used to be node Buffers, now they are Uint8Arrays
  • All deps of this module now use Uint8Arrays instead of Buffers

All uses of node Buffers have been replaced with Uint8Arrays

BREAKING CHANGES:

- The `.data`, `.from` and `.seq` properties of messages used to be
  node Buffers, now they are Uint8Arrays
- All deps of this module now use Uint8Arrays instead of Buffers
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasco-santos
Copy link
Member

We already had a 0.6 release planned in https://github.com/libp2p/js-libp2p-pubsub/tree/v0.6.x branch.
I am going to release this as 0.6 and the v0.6.x branch should be moved into 0.7.

cc @wemeetagain

@vasco-santos vasco-santos merged commit 92632b5 into master Aug 11, 2020
@vasco-santos vasco-santos deleted the fix/replace-node-buffers-with-uint8arrays branch August 11, 2020 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants