This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
feat: add onStreamEnd, muxer.streams and timeline #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
muxer.onStreamEndto allow consumers to handle any additional stream tracking they may wish to do. For example, js-libp2p will track additional metadata, such as the protocol being used on the stream.onStreamEndwill allow final metadata to be recorded and subsequent cleanup of that tracking to happen more effectively.muxer.streamsto enable consumers to get a list of all open streams a muxer has, this is particularly useful for introspection and debugging.timelinechecking on muxed streams. This provides accurate metadata for when a stream has been opened/closed.