Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup tests & vet #84

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Fixup tests & vet #84

merged 2 commits into from
Jul 15, 2021

Conversation

Stebalien
Copy link
Member

Prepare for CI deployment.

marten-seemann
marten-seemann approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t really comment on the JS changes, but the Go part lgtm.

@Stebalien
Copy link
Member Author

The JS part was "code by compiler error". But it works.

@Stebalien Stebalien merged commit 1807147 into master Jul 15, 2021
@Stebalien Stebalien deleted the chore/fixup branch July 15, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @marten-seemann