Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify: refactor observed address manager to do address mapping at thin waist(IP+TCP/UDP) layer #2793

Merged
merged 4 commits into from
May 16, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented May 15, 2024

Provides an option to disable observed address manager for users who know their external IP addresses.

@sukunrt sukunrt requested a review from MarcoPolo May 15, 2024 20:04
p2p/host/basic/basic_host.go Outdated Show resolved Hide resolved
p2p/protocol/identify/id.go Outdated Show resolved Hide resolved
p2p/protocol/identify/opts.go Show resolved Hide resolved
@MarcoPolo MarcoPolo merged commit 6861cec into master May 16, 2024
10 of 11 checks passed
ivan4th added a commit to spacemeshos/go-spacemesh that referenced this pull request Jun 6, 2024
Newer versions of libp2p has bugs introduced in libp2p/go-libp2p#2793
which break observed address handling for connections which are closed
too early.
ivan4th added a commit to spacemeshos/go-spacemesh that referenced this pull request Jun 6, 2024
Following observed address mechanism breakage in libp2p/go-libp2p#2793
disable automatic libp2p dependency bumps.
Prerequisite for re-enabling automatic updates of libp2p libs: QUIC
and routing discovery systests
@ivan4th
Copy link
Contributor

ivan4th commented Jun 7, 2024

This PR broke disconnect handling in identify, fix: #2825

spacemesh-bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this pull request Jun 7, 2024
## Motivation

libp2p/go-libp2p#2793 broke observed address handling and consequently routing discovery mechanism, too.
This is not the first time we're having problems because of (semi-)automatic libp2p dependency updates.
Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
spacemesh-bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this pull request Jun 7, 2024
## Motivation

libp2p/go-libp2p#2793 broke observed address handling and consequently routing discovery mechanism, too.
This is not the first time we're having problems because of (semi-)automatic libp2p dependency updates.
Prerequisite for re-enabling automatic updates of libp2p libs: QUIC and routing discovery systests
spacemesh-bors bot pushed a commit to spacemeshos/go-spacemesh that referenced this pull request Jun 7, 2024
## Motivation

Newer versions of libp2p has bugs introduced in libp2p/go-libp2p#2793 which break observed address handling for connections which are closed too early.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants