Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: drop support for QUIC draft-29 #2487

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

MarcoPolo
Copy link
Collaborator

@MarcoPolo MarcoPolo commented Aug 15, 2023

This does the minimal amount of changes to drop draft29 without updating quic-go.

I'm thinking, for now at least, that we'll leave machinery of the multiversion QUIC for a couple of reasons:

  1. It'll make adding support for QUIC-v2 very easy.
    a. This would mostly be greasing exercise to avoid ossification on quic-v1. There's nothing QUIC-v2 gives us that we don't have with QUIC-v1.
  2. It'll avoid us from reinventing this if we re-introduce this. This is tricky code and this code works and has been deployed for a bit.
  3. It's stable as is, and a refactor would introduce more variables to the next release (already quite big with quic-go changes).

This was referenced Aug 15, 2023
@marten-seemann marten-seemann changed the title Drop QUIC Draft 29 support quic: drop support for QUIC draft-29 Aug 16, 2023
@marten-seemann
Copy link
Contributor

Thank you for splitting up the PR @MarcoPolo!

@marten-seemann marten-seemann merged commit 9edef5a into master Aug 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants