Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm: cleanup address filtering logic #2333

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jun 5, 2023

No description provided.

@sukunrt sukunrt force-pushed the remove-udp-loopback-check branch from ecb0db4 to 505b66e Compare June 5, 2023 14:52
@marten-seemann marten-seemann changed the title swarm: remove localhost udp ports check swarm: remove localhost UDP ports checks Jun 6, 2023
@marten-seemann marten-seemann self-requested a review June 6, 2023 09:19
@sukunrt
Copy link
Member Author

sukunrt commented Jun 6, 2023

This would introduce a bug if merged as is. Converting it to draft.

@sukunrt sukunrt marked this pull request as draft June 6, 2023 09:57
@sukunrt sukunrt force-pushed the remove-udp-loopback-check branch from 505b66e to 9a1b405 Compare June 6, 2023 11:30
@sukunrt sukunrt marked this pull request as ready for review June 6, 2023 11:33
@sukunrt sukunrt marked this pull request as draft June 6, 2023 11:34
@sukunrt sukunrt changed the title swarm: remove localhost UDP ports checks swarm: cleanup address filtering logic Jun 6, 2023
@sukunrt sukunrt force-pushed the remove-udp-loopback-check branch from 9a1b405 to c63175b Compare June 6, 2023 11:56
@sukunrt sukunrt marked this pull request as ready for review June 6, 2023 12:08
@marten-seemann marten-seemann merged commit 686a32a into libp2p:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants