basichost: prevent duplicate dials #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
approved these changes
Mar 17, 2023
|
We should catch the errnocon error and return a better error |
marten-seemann
force-pushed
the
host-no-duplicate-dials
branch
from
e2bfb2a
to
ed1eea9
Compare
dennis-tra
added a commit
to dennis-tra/go-libp2p
that referenced
this pull request
Jun 16, 2023
This reverts commit 0d7e852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2195.
This fix is not perfect. The error returned will be a
network.ErrNoConn. Ideally, the swarm would not count a connection as "fully connected" before opening the first stream (and receiving something from the peer) succeeds. This will also be necessary when we implement 0-RTT.