Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autonat: return E_DIAL_REFUSED when skipping dial #1527

Merged
merged 1 commit into from
May 25, 2022

Conversation

marten-seemann
Copy link
Contributor

Discussed in libp2p/specs#411:
When skipping a dial as a server, we should return E_DIAL_REFUSED instead of E_DIAL_ERROR because we never actually tried to dial the client.

This PR replaces #1482.

@marten-seemann marten-seemann merged commit 14b1d29 into master May 25, 2022
achingbrain added a commit to libp2p/specs that referenced this pull request Jul 19, 2022
Adds a paragraph detailing when `E_DIAL_REFUSED` should be sent as
a `DialResponse` status as it's not mentioned in the current spec.

I think this is consistent with go-libp2p since libp2p/go-libp2p#1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants