Basic resource manager integration tests #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| err := echos[i].Echo(echos[0].Host.ID(), "hello libp2p") | ||
| if err != nil { | ||
| t.Log(err) |
There was a problem hiding this comment.
Why do we log here?
There was a problem hiding this comment.
mostly to make sure we have debuggability; the error is expected.
vyzo
force-pushed
the
rcmgr-itest
branch
6 times, most recently
from
ed1791f
to
ce94fad
Compare
|
made some further improvements on the tests, squashed some commits. |
marten-seemann
force-pushed
the
rcmgr
branch
2 times, most recently
from
68d94fd
to
fbab5f7
Compare
|
rebased on rcmgr branch, updated for interface changes. |
vyzo
force-pushed
the
rcmgr-itest
branch
4 times, most recently
from
0de38ce
to
6b34597
Compare
marten-seemann
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1275.