use the transport.Upgrader interface #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Jan 2, 2022
| hostType: func(h host.Host, u *tptu.Upgrader, cg connmgr.ConnectionGater) interface{} { return h }, | ||
| networkType: func(h host.Host, u *tptu.Upgrader, cg connmgr.ConnectionGater) interface{} { return h.Network() }, | ||
| muxType: func(h host.Host, u *tptu.Upgrader, cg connmgr.ConnectionGater) interface{} { return u.Muxer }, | ||
| securityType: func(h host.Host, u *tptu.Upgrader, cg connmgr.ConnectionGater) interface{} { return u.Secure }, |
There was a problem hiding this comment.
I removed the muxType and the securityType. All tests are passing, but I'm not sure this means that this is actually safe.
There was a problem hiding this comment.
IIRC, the idea was that some transports may not need the entire upgrader, and may just want a multiplexer etc. But honestly, we might as well give them an upgrader.
marten-seemann
force-pushed
the
upgrader-interface
branch
from
d044fa4
to
d7b7473
Compare
vyzo
approved these changes
Jan 2, 2022
marten-seemann
force-pushed
the
upgrader-interface
branch
from
d7b7473
to
284c6de
Compare
marten-seemann
force-pushed
the
upgrader-interface
branch
from
284c6de
to
0f0cc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.