Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

add RemovePeer method to PeerMetadata, Metrics, Protobook and Keybook #218

Merged
merged 1 commit into from
Oct 24, 2021
Merged

add RemovePeer method to PeerMetadata, Metrics, Protobook and Keybook #218

merged 1 commit into from
Oct 24, 2021

Conversation

marten-seemann
Copy link
Contributor

No description provided.

@github-actions
Copy link

gocompat says:

Branch 'master' set up to track remote branch 'master' from 'origin'.
"github.com/libp2p/go-libp2p-core/peerstore".KeyBook InterfaceChanged
"github.com/libp2p/go-libp2p-core/peerstore".PeerMetadata InterfaceChanged
"github.com/libp2p/go-libp2p-core/peerstore".Peerstore InterfaceChanged
"github.com/libp2p/go-libp2p-core/peerstore".Metrics InterfaceChanged
"github.com/libp2p/go-libp2p-core/peerstore".ProtoBook InterfaceChanged

vyzo
vyzo approved these changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have a single RemovePeer method at the top? Or will it hinder composition?

@marten-seemann
Copy link
Contributor Author

In theory, you could use these interfaces all by themselves, so I think we need to add the method everywhere.

@marten-seemann marten-seemann marked this pull request as ready for review October 24, 2021 10:17
@marten-seemann marten-seemann merged commit b18a4c9 into master Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @vyzo