This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
add a Close method, remove the context from the constructor #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll let @vyzo review first. |
vyzo
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By implementing
io.Closer, we make sure that the swarm will callClosewhen it's shutting down: https://github.com/libp2p/go-libp2p-swarm/blob/b035b90f5330de123747fe32afb3c2361f3ec0bc/swarm.go#L197-L204Note that this PR isn't implementing a clean shutdown: it doesn't make sure that all Go routines created by are actually stopped. It's not worth the effort, given that we're going to deprecate this package soon anyway.