add metrics in go-libp2p blogpost #77
Conversation
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 44.6%, saving 240.36 KB.
55 images did not require optimisation. |
|
For some reason your name is rendering like so |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 43.8%, saving 124.91 KB.
59 images did not require optimisation. |
|
@p-shahi |
can you include this change in this pr? |
sukunrt
force-pushed
the
metrics-in-go-libp2p
branch
from
94f1d7b
to
62fc4db
Compare
|
Should this blog post also mention how easy it is to use metrics locally, once we have libp2p/go-libp2p#2383? |
|
@marten-seemann that makes sense. I'll edit the post to include that. |
|
@marten-seemann Add a section titled Local development and debugging setup here |
|
Will need a small change depending on how libp2p/go-libp2p#2385 goes |
src/_blog/metrics-in-go-libp2p.md
Outdated
|
|
||
| - If you’d like to get involved and contribute to libp2p, you can reach out to us using these means: [https://libp2p.io/#community](https://libp2p.io/#community) | ||
| - If you’re a self-starter and want to start pushing code immediately, feel free to ping the maintainers in any of these help wanted/good first issues: [go-libp2p](https://github.com/libp2p/go-libp2p/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22), [js-libp2p](https://github.com/libp2p/js-libp2p/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22), and [rust-libp2p](https://github.com/libp2p/rust-libp2p/issues?q=is%3Aopen+is%3Aissue+label%3Agetting-started). | ||
| - If you want to work in and around libp2p full-time, there are various teams hiring including the implementation teams. See [https://jobs.protocol.ai/jobs?q=libp2p](https://jobs.protocol.ai/jobs?q=libp2p) for opportunities across the [Protocol Labs Network](https://plnetwork.io/). |
There was a problem hiding this comment.
Is empty?
There was a problem hiding this comment.
Changed to
- If you want to work building p2p systems full-time, there are various teams hiring. See https://jobs.protocol.ai/jobs for opportunities across the Protocol Labs Network.
|
@sukunrt are we ready to publish - I think the header image is ready right? |
|
Waiting for resolution here libp2p/go-libp2p#2385 |
|
I'll update that, but how is that a blocker? |
src/_blog/metrics-in-go-libp2p.md
Outdated
| - grafana | ||
| title: Metrics in go-libp2p | ||
| description: | ||
| date: 2023-06-15 |
There was a problem hiding this comment.
Do we need to update this?
There was a problem hiding this comment.
We can update it once we are ready to release. #77 (review)
There was a problem hiding this comment.
We shouldn't publish this post before we don't have a node connected to our public instance at libp2p.grafana.net.
Slack thread: https://filecoinproject.slack.com/archives/C03CKEPVA1Y/p1688063239680209
src/_blog/metrics-in-go-libp2p.md
Outdated
| To see the dashboards in action check the [Metrics and Dashboards](https://github.com/libp2p/go-libp2p/tree/master/examples/metrics-and-dashboards) example in the go-libp2p repo. This example sets up a dummy libp2p app configured with a Prometheus and Grafana instance. You can check all the dashboards available at <http://localhost:3000/dashboards>. | ||
|
|
There was a problem hiding this comment.
@MarcoPolo if we remove the example, I'll need to remove this.
There was a problem hiding this comment.
Just saw: libp2p/go-libp2p#2385 (comment)
As long as we are keeping the example, this is not a blocker. So we are good to go.
src/_blog/metrics-in-go-libp2p.md
Outdated
| title: Metrics in go-libp2p | ||
| description: | ||
| date: 2023-06-29 | ||
| permalink: "/2023-06-15-metrics-in-go-libp2p/" |
There was a problem hiding this comment.
| permalink: "/2023-06-15-metrics-in-go-libp2p/" | |
| permalink: "/2023-06-15-metrics-in-go-libp2p/" |
note the permalink needs to change as well. can update date and permalink the day of merge
sukunrt
force-pushed
the
metrics-in-go-libp2p
branch
from
fb78ceb
to
a2dc25b
Compare
|
@sukunrt Is this ready to merge? I think from our last discussion go-libp2p maintainers were all in agreement to display metrics from PL managed grafana (from a bifrost node). Is all that's remaining to add the right link in this post? |
@p-shahi
I don't have a lot more to add here, Once we have this and the public grafana dashboard, I'll update the details.
Please let me know if there something else we should talk about. I don't want to discuss all the metrics that we've added, I think that's better served by a doc in the go-libp2p repo.
fixes: #69