Extend --disable-ess to HTTP #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
@Hackndo's great PR for disabling Extended Session Security (ESS) in NTLMv1 (#163) was only implemented in SMB & LDAP.
This PR also implements it in HTTP. I was able to confirm successful downgrade on the HTTP server, allowing cracking of the response on crack.sh.
Looking at
packets.py, the downgrade has also not been implemented for MSSQL, RPC, and RDP. I have not implemented it on these servers as I don't know of potential side effects and cannot test them as of now.Cheers !