chore(tools/*,scripts/*): enable nx plugins with project crystal for …

…non production projects (microsoft#32337)
levithomason · Aug 23, 2024 · 3b62661 · 3b62661
1 parent 4d9fd75
commit 3b62661
Show file tree

Hide file tree

Showing 27 changed files with 28 additions and 61 deletions.
diff --git a/nx.json b/nx.json
@@ -43,7 +43,10 @@
     "test": {
       "dependsOn": [],
       "inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"],
-      "cache": true
+      "cache": true,
+      "options": {
+        "passWithNoTests": true
+      }
     },
     "test-integration": {
       "dependsOn": ["build", "^build"],
@@ -73,7 +76,10 @@
         "{workspaceRoot}/.eslintrc.json",
         "{workspaceRoot}/.eslintignore",
         "{workspaceRoot}/eslint.config.js"
-      ]
+      ],
+      "options": {
+        "command": "eslint src"
+      }
     },
     "verify-packaging": {
       "dependsOn": ["build"],
@@ -116,5 +122,21 @@
   },
   "parallel": 3,
   "useInferencePlugins": false,
-  "defaultBase": "master"
+  "defaultBase": "master",
+  "plugins": [
+    {
+      "plugin": "@nx/jest/plugin",
+      "options": {
+        "targetName": "test"
+      },
+      "include": ["tools/**/*", "scripts/**/*"]
+    },
+    {
+      "plugin": "@nx/eslint/plugin",
+      "options": {
+        "targetName": "lint"
+      },
+      "include": ["tools/**/*", "scripts/**/*"]
+    }
+  ]
 }
diff --git a/scripts/api-extractor/package.json b/scripts/api-extractor/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/babel/package.json b/scripts/babel/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/beachball/package.json b/scripts/beachball/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/cypress/package.json b/scripts/cypress/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/dangerjs/package.json b/scripts/dangerjs/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/executors/package.json b/scripts/executors/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/github/package.json b/scripts/github/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/gulp/package.json b/scripts/gulp/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/jest/package.json b/scripts/jest/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/lint-staged/package.json b/scripts/lint-staged/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/monorepo/jest.config.js b/scripts/monorepo/jest.config.js
@@ -10,6 +10,7 @@ module.exports = {
     '^.+\\.tsx?$': ['@swc/jest', {}],
   },
   coverageDirectory: './coverage',
+  testTimeout: 20000,
   testEnvironment: 'node',
   setupFiles: ['<rootDir>/jest-setup.js'],
 };
diff --git a/scripts/monorepo/package.json b/scripts/monorepo/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/package-manager/package.json b/scripts/package-manager/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/perf-test-flamegrill/package.json b/scripts/perf-test-flamegrill/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "peerDependencies": {

diff --git a/scripts/prettier/package.json b/scripts/prettier/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/projects-test/package.json b/scripts/projects-test/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/puppeteer/package.json b/scripts/puppeteer/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/storybook/package.json b/scripts/storybook/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/tasks/package.json b/scripts/tasks/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/triage-bot/package.json b/scripts/triage-bot/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/ts-node/package.json b/scripts/ts-node/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/update-release-notes/package.json b/scripts/update-release-notes/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/scripts/utils/package.json b/scripts/utils/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {},

diff --git a/scripts/webpack/package.json b/scripts/webpack/package.json
@@ -6,8 +6,6 @@
   "scripts": {
     "format": "prettier -w --ignore-path ../../.prettierignore .",
     "format:check": "yarn format -c",
-    "lint": "eslint --ext .ts,.js ./src",
-    "test": "jest --passWithNoTests",
     "type-check": "just-scripts type-check"
   },
   "dependencies": {

diff --git a/tools/eslint-rules/project.json b/tools/eslint-rules/project.json
@@ -3,14 +3,6 @@
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "tools/eslint-rules",
   "projectType": "library",
-  "targets": {
-    "test": {
-      "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
-      "options": {
-        "jestConfig": "tools/eslint-rules/jest.config.ts"
-      }
-    }
-  },
-  "tags": ["platform:node", "tools"]
+  "tags": ["platform:node", "tools"],
+  "targets": {}
 }
diff --git a/tools/workspace-plugin/package.json b/tools/workspace-plugin/package.json
@@ -6,9 +6,7 @@
   "generators": "./generators.json",
   "executors": "./executors.json",
   "scripts": {
-    "test": "jest --passWithNoTests",
     "type-check": "node  ./scripts/type-check.mjs",
-    "lint": "eslint --ext .ts,.js,.json .",
     "check-graph": "node ./scripts/check-dep-graph.js"
   },
   "dependencies": {