Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix(sticky-turbo): do not hard code path separator #154

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

fuxingloh
Copy link
Contributor

What this PR does / why we need it:

Do not hard code path separator and use sep from node:path.

Which issue(s) will this PR fix?:

Fixes #93

@netlify
Copy link

netlify bot commented Jun 4, 2023

Deploy Preview for sticky-birthday ready!

Name Link
🔨 Latest commit d829eb3
🔍 Latest deploy log https://app.netlify.com/sites/sticky-birthday/deploys/647be101af4c1200088c9aec
😎 Deploy Preview https://deploy-preview-154--sticky-birthday.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #154 (d829eb3) into main (71d60a1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #154   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files           7        7           
  Lines         176      176           
  Branches       19       19           
=======================================
  Hits          128      128           
  Misses         45       45           
  Partials        3        3           
Impacted Files Coverage Δ
packages/sticky-turbo/src/Turbo.ts 81.69% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuxingloh fuxingloh merged commit 00cfafb into main Jun 4, 2023
@fuxingloh fuxingloh deleted the fuxingloh/do-not-hard-code-path-join branch June 4, 2023 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sticky-jest and sticky-turbo-jest - Support for Windows devices
1 participant