This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
feat(turbo): support extends on turbo.json and detecting turbo to prevent re-invocation
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(sticky-jest-turbo): detect turbo is the current process to prevent re-invocation chore(*): fix wrong lint script This PR contains breaking changes when `sticky-turbo` is used programmatically.
✅ Deploy Preview for sticky-birthday ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 67.39% 72.72% +5.33%
==========================================
Files 5 7 +2
Lines 92 176 +84
Branches 3 19 +16
==========================================
+ Hits 62 128 +66
- Misses 30 45 +15
- Partials 0 3 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I think this PR might solve this #93 |
| const paths = cwd.split('/'); | ||
|
|
||
| for (let i = 0; i < depth; i += 1) { | ||
| const path = `${paths.join('/')}/turbo.json`; |
There was a problem hiding this comment.
Ah maybe not because we still hardcode it to "/"
There was a problem hiding this comment.
Let me fix this in another PR
thedoublejay
approved these changes
May 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
@levaintech maintains an internal fork of sticky, this PR syncs the quality of life update that were introduced to turbo.
extends: [//]on turbo.json, see https://turbo.build/repo/docs/core-concepts/monorepos/configuring-workspacestsconfig.jsonAdditional comments?:
This PR contains breaking changes when
sticky-turbois used programmatically.