Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for zm.page links #731

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

bgjooon
Copy link
Contributor

@bgjooon bgjooon commented Jun 2, 2024

Status

READY

Description

A few folks at the company where I work use zm.page links (for shortened Zoom links) and also MeetingBar. Figured I'd try to add in support for the links.

I followed what I saw in

App built successfully after making the changes, but I figure I made at least one mistake. Glad to make any additional modifications needed!

Checklist

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New feature or request labels Jun 2, 2024
@bgjooon
Copy link
Contributor Author

bgjooon commented Jun 17, 2024

@leits hoping I followed all the steps, but please let me know if I need to make any modifications here. very excited to contribute!

@leits
Copy link
Owner

leits commented Jun 17, 2024

Hi @bgjooon,
Thanks for the pull requests!
Looks great, I'll add it to the next release scope!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2024
@leits leits merged commit 4fd4864 into leits:master Jun 17, 2024
8 checks passed
@bgjooon bgjooon deleted the support-zm-page-links branch June 17, 2024 17:39
@bgjooon bgjooon restored the support-zm-page-links branch June 17, 2024 17:39
@bgjooon bgjooon deleted the support-zm-page-links branch June 17, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants