Remove the -t flag (#38)

README.md

@@ -43,9 +43,9 @@ gochecknoglobals [package]
 gochecknoglobals ./...
 ```
 
-By default, test files will not be checked but can be included by adding the
-`-t` flag.
+By default, test files are checked but can be excluded by adding the
+`-test=false` flag.
 
 ```
-gochecknoglobals -t [package]
+gochecknoglobals -test=false [package]
 ```

checknoglobals/check_no_globals.go

@@ -1,7 +1,6 @@
 package checknoglobals
 
 import (
-	"flag"
 	"fmt"
 	"go/ast"
 	"go/token"
@@ -37,18 +36,10 @@ func Analyzer() *analysis.Analyzer {
 		Name:             "gochecknoglobals",
 		Doc:              Doc,
 		Run:              checkNoGlobals,
-		Flags:            flags(),
 		RunDespiteErrors: true,
 	}
 }
 
-func flags() flag.FlagSet {
-	flags := flag.NewFlagSet("", flag.ExitOnError)
-	flags.Bool("t", false, "Include tests")
-
-	return *flags
-}
-
 func isAllowed(cm ast.CommentMap, v ast.Node, ti *types.Info) bool {
 	switch i := v.(type) {
 	case *ast.GenDecl:
@@ -138,16 +129,11 @@ func hasEmbedComment(cm ast.CommentMap, n ast.Node) bool {
 }
 
 func checkNoGlobals(pass *analysis.Pass) (interface{}, error) {
-	includeTests := pass.Analyzer.Flags.Lookup("t").Value.(flag.Getter).Get().(bool)
-
 	for _, file := range pass.Files {
 		filename := pass.Fset.Position(file.Pos()).Filename
 		if !strings.HasSuffix(filename, ".go") {
 			continue
 		}
-		if !includeTests && strings.HasSuffix(filename, "_test.go") {
-			continue
-		}
 
 		fileCommentMap := ast.NewCommentMap(pass.Fset, file, file.Comments)